New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uberon labels with VSAO labels #59
Comments
A few comments: For girdle complexes, I agree with you- the slashes were from earlier in the discussion and I don't think we want them. For UBERON_0000383 "musculature of body" -vs- VSAO:0000033 "muscular system" - the definition of the VSAO class doesn't really refer to a system per se, it refers to the merological sum, and therefore I prefer the uberon label. For all examples of univocity, I agree with the need and we should keep what is in uberon. For UBERON_0005944 "axial skeleton plus cranial skeleton" -vs- VSAO:0000056 "axial skeleton", I preferred: axial skeleton I was outvoted...but this may have been why was labeled as such. UBERON_0008895 "splanchnocranium" -vs- VSAO:0000149 "pharyngeal arch" UBERON_0010323 "cranial skeletal system" -vs- VSAO:0000049 "cranial skeleton" UBERON_0007380 "dermal scale" -vs- VSAO:0000048 "scale" UBERON_0002101 "limb" -vs- VSAO:0000121 "free limb" "paired appendage" is less clear. I would rather avoid this until the Perhaps can leverage concepts of bilateral symmetry here. For a future conversation elsewhere. UBERON_0005863 "cartilaginous condensation" -vs- VSAO:0000092 "chondrogenic condensation" UBERON_0002091 "entire appendicular skeleton" -vs- VSAO:0000076 "appendicular skeleton" UBERON_0004743 "coracoid bone" -vs- VSAO:0000158 "coracoid" UBERON_0001479 "sesamoid bone" -vs- VSAO:0000137 "sesamoid" Thanks Chris for putting this together. -m |
Note from Robert: centrum and body of vertebra are not quite equivalent |
Musculature of body: See issue #77 |
Sesamoids: created separate classes, such that we have sesamoid element and sesamoid bone as subclass |
I assigned this to you Wasila, since you created the original VSAO terms. I suggest a two-pass approach. If Paula is roughly happy with the naming conventions we have now, we will remove this from the milestone, but keep the issue as something to be analyzed in more detail in the future. |
…n. Relabeled skeletons for auto, meta and meso to use relational adjectival form. Partially addresses #59
* NTs: internal and external cheek pouches * NTs: for various papillae of tongue (horny, mechanical) * NT: epithelium of intestinal villus; tidied epithelium of logical defs * NTs: intertrochanteric line and crest * renaming cartilaginous element to cartilage element according to VSAO. Partially addresses issue 59 * renaming acropodial and limb/fin skeleton according to VSAO. Partially addresses issue 59 * renaming pec/pelv girdle skeleton to use WP rather than P of W pattern. Relabeled skeletons for auto, meta and meso to use relational adjectival form. Partially addresses #59
A note about bone element/bone tissue: Currently uberon has 'bone' as the label for UBERON:0001474 -- the skeletal element. We decided on 'bone element' in VSAO to avoid confusion with 'bone tissue'. both of these terms have related synonym "bone". I think we should go back to the VSAO labels and synonyms here. Similarly, need to add related synonym 'cartilage' to 'cartilage element' and 'cartilage tissue' |
I agree. On Tue, Feb 19, 2013 at 3:19 PM, wdahdul notifications@github.com wrote:
|
Paula and I reviewed the original list and just have comment for this item: Also, I'd still like to review the axial skeleton item but otherwise the changes can go through for this week's release. Thanks! |
Hi Chris -- I caught up with the axial/postaxial/cranial skeleton proposal and agree (going on notes found here: |
are we happy with the current state of things? If so I will close this. |
Just noticed in phenoscape-ext (perhaps it's fixed in core already?):
Other than that, please close the request. Thanks! |
changed 'appendage segment' to ' subdivision of organism along appendicular axis' NT: body proper NT: integumentary projection changed 'skin adnexa' to the more generic 'integumentary adnexa' added doap-mailing list property * NT: axiom musculature foot pad syns fixes #59 * NTs: pubic and axillary hair; def changes: white and brown adipose tissue NT: exocrine pancreas epithelium xrefs from CALOHA NTs: brain, colon endothelium; tonsil epithelium. Addresses #227 fixes #226 syns for comma/S shaped bodies fixed syntax error documenting axiom annotations doap fixed def of arachnoid trabecula Added lydie/nextprot as contributors TS ovum xref removed. Belongs in CL. Addresses #224 Remaining 2 xrefs. Addresses #223 TS synovium xref. Addresses #224 NT: cerebral cortex neuropil. Addresses #223 NT: Inframammary fold. Addresses #223 NT: buttock. Sourced from various sources. Note that we do not add all the synonyms from dbpedia. Addresses #223 NT: appendix lymphoid tissue. Addresses #223 NT: tonsil germinal center. Addresses #223 Some notes that addresses #225 relabeled endothelium of lymphatic vessel fixed umls xref notes for endothelium taxon constraint on epithelium
changed 'appendage segment' to ' subdivision of organism along appendicular axis' NT: body proper NT: integumentary projection changed 'skin adnexa' to the more generic 'integumentary adnexa' added doap-mailing list property * NT: axiom musculature foot pad syns fixes #59 * NTs: pubic and axillary hair; def changes: white and brown adipose tissue NT: exocrine pancreas epithelium xrefs from CALOHA NTs: brain, colon endothelium; tonsil epithelium. Addresses #227 fixes #226 syns for comma/S shaped bodies fixed syntax error documenting axiom annotations doap fixed def of arachnoid trabecula Added lydie/nextprot as contributors TS ovum xref removed. Belongs in CL. Addresses #224 Remaining 2 xrefs. Addresses #223 TS synovium xref. Addresses #224 NT: cerebral cortex neuropil. Addresses #223 NT: Inframammary fold. Addresses #223 NT: buttock. Sourced from various sources. Note that we do not add all the synonyms from dbpedia. Addresses #223 NT: appendix lymphoid tissue. Addresses #223 NT: tonsil germinal center. Addresses #223 Some notes that addresses #225 relabeled endothelium of lymphatic vessel fixed umls xref notes for endothelium taxon constraint on epithelium
Note that this issue pertains only to primary labels. Full synonym
lists will of course be retained.
No discussion required
In all of the following, the Uberon label will be replaced by the VSAO
one. Where possible, this will be propagated to dependent ontologies.
Naming convention differences
VSAO tends to use relational adjectival form whereas Uberon uses a
mixture of more explicit FMA-style labels plus relational adjectives
depending on factors such as whether the label is reused in
compositional classes.
All of the following will be switched to the VSAO label
STATUS: DONE
See further down form limb/fin vs paired appendage.
Non-trivial differences
The Uberon label will be replaced by the VSAO label here
Additional discussion required
Girdle complexes
The uberon labels were chosen on the basis of previous discussions. A
slash typically denotes "or", which would be misleading here, as the
class refers to the mereological sum. I would therefore advise keeping
the labels as-is.
Muscles
This can be changed, but the name was deliberately chosen to reflect that this is the mereological sum of all muscles of the body.
Univocity requirements
Sometimes an Uberon label was chosen over a VSAO label, as VSAO was
originally designed purely with verteberate skeletal systems in mind,
whereas additional disambiguation is required when placing this in a
metazoan multi-system context.
In all 3 cases here I would recommend retaining the existing primary
label.
Note that in all cases it is possible to have a context-specific
primary label, but the default primary label must be unambiguous for
the context of the whole ontology.
Uberon follows FMA and other ontologies in including non-skeletal
joints such as gastro-splenic ligament. In a purely skeletal context "joint"
is unambiguous, but in a broader context it is necessary to include a
disambiguating prefix.
"process" is ambiguous in a multi-ontology context. "anatomical
projection", whilst ugly, is unambiguous. (of course, these high level
terms would be hidden from most users by applications anyway)
"subdivision of skeleton" is umabiguous. However, it's not clear
whether "skeletal subvision" refers to a subdivision of the skeleton
or the skeletal system (recall the latter is broader, and includes
joint).
Other
This was based on the opinions of the phenoscape curators on the most
recent obo-anatomy call. Too complex to summarise here, see:
[https://docs.google.com/document/d/16JZOuH9sh_a8uIXA4cqg0Q1H6MV5yCj3-rhuKsZoV_U/edit](appendicular skeleton) docs
I would strongly recommend we retain the existing label.
Note the VSAO class was part of "cranial skeleton". It had no defs or
synonyms or is_a parent, but was assumed to be intended to be
equivalent to what in uberon is called the splanchnocranium (the
endochondral parts of the cranial skeleton derived from pharyngeal
arches - system based on Kardong).
I strongly recommend the uberon label is retained here. In most
ontologies "pharyngeal arch" does not refer to the skeleton, but
instead to the embryological structures.
See [https://docs.google.com/document/d/1r9kNPpFYGdu0SpJDLyFAVQczBlG0wAZCBMd18gG3Ot8/edit#](cranial terms)
Whilst "cranial skeletal system" is an ugly term, it is important we
retain consistent terminology. In previous version of VSAO we agreed
to follow the FMA system of using "skeletal system" for joints + other
skeletal elements and dividing this into skeleton and articular
system. This has certain consequences - for example, if sutures are
considered joints, then under this system they are part of the
articular system and its parent the skeletal system, but not skeleton.
"scale" can be ambiguous outside a vertebrate skeletal
context. However, more work is required here. The current subclasses
in Uberon are I believe all dermal.
Limb/free limb and paired appendage
We should use "free limb" as in VSAO. Uberon will be changed to
reflect this. This will not be immediate, as we are also changing the
multiple compositional terms that use this, and checking whether the
corresponding terms in other AOs refer to the free limb or complex
(this is almost done).
"paired appendage" is less clear. I would rather avoid this until the
appendage definition is finalized in CARO2. Also "paired appendage" is
ambiguous in a metazoan context. We explicitly want to include insect
legs here (these are grouped under a more generic class)
If we go with this change, I would like it to be synchronized across
multiple ontologies. Note that EHDAA2 uses "cartilage/inous
condensation" exclusively
We can change this back. The explicit naming was designed to eliminate
confusion whereby in some ontologies "appendicular skeleton" was used
as the superclass of the individual limb/fin skeletons
The VSAO class and the uberon class denote bones.
Should this be in fact split into two classes? Many of the existing
sesamoid subclasses in Uberon are bones and users would expect to find
them in a query for bones ("ossicle" is not a subclass of bone element
in VSAO)
The text was updated successfully, but these errors were encountered: